JIT: add option to choose guarded devirt class randomly #53399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a config setting to randomly choose one of the observed classes for guarded devirtualization, rather than the most likely class.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib |
BruceForstall
approved these changes
May 28, 2021
EgorBo
reviewed
May 28, 2021
| // | ||
| // This code can runs without a jit instance present, so JITDUMP and related | ||
| // cannot be used. | ||
| // |
There was a problem hiding this comment.
BTW, so do we want to be able to return LikelyClass even without the PGO (class probes) for interfaces/classes with known single implementations? E.g. ILLink, during trimming, could compose a list, save to a file and jit could consult with it.
There was a problem hiding this comment.
Anything text-based might be tricky to get right in general (parsing generics, etc). It's not clear to me how robust our setup is to potentially truly random guesses.
EgorBo
approved these changes
May 28, 2021
CertifiedRice
approved these changes
May 29, 2021
|
Linker test failure is almost certainly unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config setting to randomly choose one of the observed classes for
guarded devirtualization, rather than the most likely class.