-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate targets files that throws for unsupported netstandard applicable tfms #53244
Conversation
For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a targets file to mark the .NETStandard asset as not applicable. This was done to allow defining a minimum supported .NETCoreApp version, even though a compatible .NETStandard asset is available. This commit automatically generates that targets file based on items.
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsFor S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a This is a port of the commit from #53023.
|
Hello @ViktorHofer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
<None Include="$(PlaceholderFile)" | ||
PackagePath="buildTransitive\%(NETStandardCompatError.Supported)" | ||
Pack="true" /> | ||
<FileWrites Include="$(_NETStandardCompatErrorFilePath)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean may not work correctly for pkgproj, but test this out for csproj if you have a chance. Clean does some weird things with paths based on where they are wrt output path
Merging as the allconfigurations builds passed. wasm failures are likely: #53180 |
For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a
targets file to mark the .NETStandard asset as not applicable.
This was done to allow defining a minimum supported .NETCoreApp
version, even though a compatible .NETStandard asset is available.
This commit automatically generates that targets file based on
items.
This is a port of the commit from #53023.