Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate targets files that throws for unsupported netstandard applicable tfms #53244

Merged
merged 5 commits into from
May 26, 2021

Conversation

ViktorHofer
Copy link
Member

For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a
targets file to mark the .NETStandard asset as not applicable.
This was done to allow defining a minimum supported .NETCoreApp
version, even though a compatible .NETStandard asset is available.
This commit automatically generates that targets file based on
items.

This is a port of the commit from #53023.

For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a
targets file to mark the .NETStandard asset as not applicable.
This was done to allow defining a minimum supported .NETCoreApp
version, even though a compatible .NETStandard asset is available.
This commit automatically generates that targets file based on
items.
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 25, 2021
@ViktorHofer ViktorHofer requested review from ericstj and Anipik May 25, 2021 18:06
@ViktorHofer ViktorHofer self-assigned this May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a
targets file to mark the .NETStandard asset as not applicable.
This was done to allow defining a minimum supported .NETCoreApp
version, even though a compatible .NETStandard asset is available.
This commit automatically generates that targets file based on
items.

This is a port of the commit from #53023.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: 6.0.0

@ViktorHofer ViktorHofer changed the title Generate targets files that throw for unsupported NS tfm Generate targets files that throws for unsupported netstandard applicable tfms May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Directory.Build.targets Outdated Show resolved Hide resolved
<None Include="$(PlaceholderFile)"
PackagePath="buildTransitive\%(NETStandardCompatError.Supported)"
Pack="true" />
<FileWrites Include="$(_NETStandardCompatErrorFilePath)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean may not work correctly for pkgproj, but test this out for csproj if you have a chance. Clean does some weird things with paths based on where they are wrt output path

@ViktorHofer
Copy link
Member Author

Merging as the allconfigurations builds passed. wasm failures are likely: #53180

@ViktorHofer ViktorHofer merged commit 293d472 into dotnet:main May 26, 2021
@ViktorHofer ViktorHofer deleted the NSSupportedTarget branch May 26, 2021 10:09
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants