Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CAST(int <- long) on 32 bit targets #53040

Merged
merged 9 commits into from
Jun 25, 2021
Merged

Optimize CAST(int <- long) on 32 bit targets #53040

merged 9 commits into from
Jun 25, 2021

Commits on Jun 2, 2021

  1. Optimize CAST(int <- long) on 32 bit targets

    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b84e971 View commit details
    Browse the repository at this point in the history

  2. Revert "Optimize CAST(int <- long) on 32 bit targets" 

    Revert the implementation in lowering
    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    ce8317a View commit details
    Browse the repository at this point in the history

  3. Optimize CAST(int <- long) on 32 bit targets 

    Move the code from lowering to long decomposition.
    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    793790b View commit details
    Browse the repository at this point in the history

  4. Fixed the "Arguments" note for DecomposeNode

    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    5a56b92 View commit details
    Browse the repository at this point in the history

  5. Added the function header 

    For OptimizeCastFromDecomposedLong.
    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    9782f3c View commit details
    Browse the repository at this point in the history

  6. Remove the TODO comment 

    While correct, it has questionable value.
    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    050041c View commit details
    Browse the repository at this point in the history

  7. Add a more detailed dump output

    @SingleAccretion
    SingleAccretion committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    bb0b7d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. Do not try to optimize checked casts 

    It is easy to get it wrong. Let the frontend handle this.
    @SingleAccretion
    SingleAccretion committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    11301fd View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Do not depend on tree order 

    Previous version of the code assumed that there could be
no nodes between the cast and its operand. That is not
a correct assumption to make in LIR.
    @SingleAccretion
    SingleAccretion committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    b6ddd26 View commit details
    Browse the repository at this point in the history