Use IValueTaskSource in PipeStream on Windows #52695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @carlossanlop Issue DetailsUse IValueTaskSource in NamedPipeServerStream on Windows Closes #51463 /cc @stephentoub
|
carlossanlop
requested review from
jozkee,
stephentoub,
carlossanlop and
adamsitnik
src/libraries/System.IO.Pipes/src/System/IO/Pipes/ConnectionValueTaskSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 24, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 24, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeValueTaskSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 24, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeValueTaskSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 25, 2021
src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeStream.Windows.cs
Outdated
Show resolved
Hide resolved
manandre
force-pushed
the
pipestream-ivaluetasksource
branch
3 times, most recently
from
a98fa7c
to
3ab26fb
Compare
terrajobst
added
the
community-contribution
|
@stephentoub This PR is assigned to you for follow-up/decision before the RC1 snap. |
stephentoub
force-pushed
the
pipestream-ivaluetasksource
branch
from
3ab26fb
to
a218fed
Compare
|
I pushed a commit to revise the implementation to match the latest in FileStream. As for the perf tests, the tests themselves aren't great. I've revised them in dotnet/performance#1897. The relevant ones look fine:
|
|
@adamsitnik, can you review? Thanks. |
stephentoub
force-pushed
the
pipestream-ivaluetasksource
branch
from
a218fed
to
64664c2
Compare
stephentoub
force-pushed
the
pipestream-ivaluetasksource
branch
from
64664c2
to
e648ecf
Compare
|
There's a real test failure happening here, and I'm trying to figure out why. So far it's only occurred on x86 on Windows 7. |
stephentoub
force-pushed
the
pipestream-ivaluetasksource
branch
from
e648ecf
to
b0caf4c
Compare
Better match implementation in RandomAccess
stephentoub
force-pushed
the
pipestream-ivaluetasksource
branch
from
b0caf4c
to
f6adcb7
Compare
This was referenced Aug 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use IValueTaskSource in NamedPipeServerStream on Windows
Remove PipeCompletionSource
Closes #51463
/cc @stephentoub