Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Microsoft.NETCore.Targets package #52261

Merged
merged 1 commit into from
May 5, 2021

Conversation

ViktorHofer
Copy link
Member

That package was needed in the 1.x timeframe and later in 2.x brought
back to trim out 1.x runtime references. As the live version of that
package isn't directly referenced anymore by any component in at least
the dotnet org. Source build has a checked in state so that the
dependent packages in 2.x can still build with it.

That package was needed in the 1.x timeframe and later in 2.x brought
back to trim out 1.x runtime references. As the live version of that
package isn't directly referenced anymore by any component in at least
the dotnet org. Source build has a checked in state so that the
dependent packages in 2.x can still build with it.
@ghost
Copy link

ghost commented May 4, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

That package was needed in the 1.x timeframe and later in 2.x brought
back to trim out 1.x runtime references. As the live version of that
package isn't directly referenced anymore by any component in at least
the dotnet org. Source build has a checked in state so that the
dependent packages in 2.x can still build with it.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj
Copy link
Member

ericstj commented May 4, 2021

dotnet/sdk#3044 talked about the problem that brought this package back.
#47110 describes its purpose.
Adding these to help folks see the connection.

@ViktorHofer ViktorHofer merged commit c7a4c36 into dotnet:main May 5, 2021
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants