Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/use get last p invoke error #52212

Merged
merged 10 commits into from
May 9, 2021

Conversation

KZedan
Copy link
Contributor

@KZedan KZedan commented May 3, 2021

Replacing the last GetLastWin32Error calls in corelib.

Fixes #51648

@KZedan KZedan force-pushed the Task/Use_GetLastPInvokeError branch 7 times, most recently from 5fc8fe4 to 5e2d08b Compare May 8, 2021 15:00
@KZedan KZedan force-pushed the Task/Use_GetLastPInvokeError branch from 5e2d08b to f814d89 Compare May 8, 2021 15:42
@KZedan
Copy link
Contributor Author

KZedan commented May 8, 2021

@jkotas I believe this should be all of them.

Fixes #51648

@KZedan KZedan marked this pull request as ready for review May 8, 2021 23:18
@ghost
Copy link

ghost commented May 9, 2021

Hello @jkotas!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkotas jkotas removed the auto-merge label May 9, 2021
@jkotas jkotas merged commit b08a97a into dotnet:main May 9, 2021
@jkotas
Copy link
Member

jkotas commented May 9, 2021

Thank you!

@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Marshal.GetLastPInvokeError instead of Marshal.GetLastWin32Error in NETCoreApp
3 participants