Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon reenable 49568 #52202

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Apple Silicon reenable 49568 #52202

merged 1 commit into from
Jun 10, 2021

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented May 3, 2021

CI likely fixed by dotnet/core-eng#12776

Fixes #49568

@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

CI likely fixed by dotnet/core-eng#12776

Fixes #49568

Author: sdmaclea
Assignees: sdmaclea
Labels:

arch-arm64, area-Infrastructure-libraries, os-mac-os-x-big-sur

Milestone: 6.0.0

@sdmaclea
Copy link
Contributor Author

sdmaclea commented May 3, 2021

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea
Copy link
Contributor Author

sdmaclea commented May 3, 2021

@sdmaclea
Copy link
Contributor Author

First runs passed. Fixed merge conflict. Triggering runs again.

@sdmaclea
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj
Copy link
Member

ericstj commented Jun 7, 2021

@sdmaclea does this need a rerun or do you think these weren't fixed by dotnet/core-eng#12776?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

These weren't fixed by dotnet/core-eng#12776.

Unfortunately most of these issues do not reproduce (easily?) locally anymore.

The original runs didn't generate core dumps. The coredumps have since been fixed. I planned to rebase and rerun these to see if we could get some more info.

/cc @janvorli @mangod9 @sandreenko

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

@sdmaclea sdmaclea marked this pull request as draft June 8, 2021 18:50
@sdmaclea sdmaclea marked this pull request as ready for review June 9, 2021 23:31
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 9, 2021

This needs a review, The Apple Silicon tests all passed.

@safern PTAL

@sdmaclea sdmaclea requested a review from mangod9 June 10, 2021 00:21
@sdmaclea sdmaclea merged commit d66e936 into dotnet:main Jun 10, 2021
@sdmaclea sdmaclea deleted the reenable49568 branch June 10, 2021 00:27
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS-arm64] CoreCLR - Libraries intermittent failures
3 participants