-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS] Make the managed code depending on System.Net.Security.Native throw PNSE #51861
[tvOS] Make the managed code depending on System.Net.Security.Native throw PNSE #51861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interop files for P/Invoke still need to be removed from the build (.csproj). Otherwise the Xamarin tooling will see them unless a Linker is enabled.
Not sure what is the file name convention for the PNSE files. Some pre-existing sources use the .PlatformNotSupported.cs
suffix which is what I ended up using in my (not yet reviewed/approved) PRs.
f8a7bb9
to
8672941
Compare
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Show resolved
Hide resolved
cb61096
to
7d9a449
Compare
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Microsoft/Win32/SafeHandles/GssSafeHandles.PlatformNotSupported.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#45535