Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Net.Sockets readonly annotation #51809

Closed
wants to merge 3 commits into from
Closed

System.Net.Sockets readonly annotation #51809

wants to merge 3 commits into from

Conversation

hrrrrustic
Copy link
Contributor

This PR is a part of #46675

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is a part of #46675

Author: hrrrrustic
Assignees: -
Labels:

area-System.Net.Sockets, new-api-needs-documentation
Milestone: -

Wraith2
Wraith2 reviewed Apr 25, 2021
View reviewed changes
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketInformation.cs Outdated
Comment on lines 8 to 10
public byte[] ProtocolInformation { readonly get; set; }
public SocketInformationOptions Options { readonly get; set; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these aren't needed, the docs state:

The compiler declares a get accessor of an auto-implemented property as readonly, regardless of presence of the readonly modifier in a property declaration.

However, it isn't harmful or incorrect.

@jeffhandley jeffhandley marked this pull request as draft April 29, 2021 20:48
@jeffhandley
Copy link
Member

This PR is being marked as a draft per #46675 (comment).

@ghost ghost closed this May 29, 2021
@ghost
Copy link

ghost commented May 29, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 28, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wraith2 Wraith2 Wraith2 left review comments

Assignees
No one assigned
Labels
area-System.Net.Sockets new-api-needs-documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hrrrrustic @jeffhandley @Wraith2 @karelz