-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use runtimconfig.template.json file for Android functional test for JIT #50612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly seems ok, but I'm not sure we want to hardcode the same runtimeconfig.template.json into every testsuite. We should instead pick up whatever each testsuite ends up generating in runtimeconfig.json
during its publish step.
also in the C file we should heap allocate the file_path.
src/tests/FunctionalTests/Android/Device_Emulator/JIT/Program.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
native code LGTM. I don't like "output.pefile" as a name. And I think the msbuild property names are a bit too generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits, but generally LGTM.
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
CI lane |
Update Android functional test for JIT to leverage newly added feature - Mobile runtimeconfig.json support (#49237)