Use runtimconfig.template.json file for Android functional test for JIT #50612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
lambdageek,
CoffeeFlux,
akoeplinger,
MaximLipnin,
steveisok and
SamMonoRT
lambdageek
requested changes
Apr 1, 2021
There was a problem hiding this comment.
mostly seems ok, but I'm not sure we want to hardcode the same runtimeconfig.template.json into every testsuite. We should instead pick up whatever each testsuite ends up generating in runtimeconfig.json during its publish step.
also in the C file we should heap allocate the file_path.
src/tests/FunctionalTests/Android/Device_Emulator/JIT/Program.cs
Outdated
Show resolved
Hide resolved
lambdageek
approved these changes
Apr 2, 2021
marek-safar
reviewed
Apr 5, 2021
marek-safar
reviewed
Apr 5, 2021
CoffeeFlux
approved these changes
Apr 5, 2021
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
Co-authored-by: Ryan Lucia <[email protected]>
|
CI lane |
CoffeeFlux
reviewed
Apr 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Android functional test for JIT to leverage newly added feature - Mobile runtimeconfig.json support (#49237)