Clean up string formatting in a variety of places #50267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
reviewed
Mar 26, 2021
src/coreclr/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs
Outdated
Show resolved
Hide resolved
benaadams
reviewed
Mar 26, 2021
...braries/System.Diagnostics.FileVersionInfo/src/System/Diagnostics/FileVersionInfo.Windows.cs
Outdated
Show resolved
Hide resolved
benaadams
reviewed
Mar 26, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeTypedArgument.cs
Show resolved
Hide resolved
benaadams
reviewed
Mar 26, 2021
src/libraries/System.Threading.Tasks.Dataflow/src/Base/DataflowBlock.cs
Outdated
Show resolved
Hide resolved
benaadams
reviewed
Mar 26, 2021
src/libraries/System.Threading.Tasks.Dataflow/src/Base/DataflowBlock.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
stringformat
branch
from
444d8eb to
67001df
Compare
|
Thanks, @benaadams. |
stephentoub
force-pushed
the
stringformat
branch
2 times, most recently
from
36172ca to
866bc9a
Compare
Mostly just replacing string.Format calls with equivalent interpolated string uses. In some cases, I replaced lots of string creations with a StringBuilder or equivalent.
stephentoub
force-pushed
the
stringformat
branch
from
866bc9a to
f7504de
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just replacing string.Format calls with equivalent interpolated string uses. In some cases, I replaced lots of string creations with a StringBuilder or equivalent.