Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big-endian test case fixes: Xoshiro hash #49709

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Big-endian test case fixes: Xoshiro hash #49709

merged 2 commits into from
Mar 19, 2021

Conversation

uweigand
Copy link
Contributor

  • Skip endian-dependent part of Xoshiro_AlgorithmBehavesAsExpected on
    big-endian systems

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

* Skip Xoshiro_AlgorithmBehavesAsExpected on big-endian systems
@uweigand
Copy link
Contributor Author

@stephentoub Looks like our last two updates crossed each other, sorry. Thanks for the quick Arcade fix! However, if I understand things correctly, this new feature won't be available to "runtime" until there's a new release of Arcade (the Microsoft.DotNet.XUnitExtensions package) and that new release is then pulled into runtime, right?

Should we just wait until that happens, or would my latest version of this patch using the intermediate local property be acceptable to merge as interim solution:

        public static bool IsLittleEndian => BitConverter.IsLittleEndian;
        [ConditionalFact(nameof(IsLittleEndian))]

@danmoseley
Copy link
Member

You should be able to just wait for #49820

@akoeplinger akoeplinger merged commit 3042a66 into dotnet:main Mar 19, 2021
@uweigand
Copy link
Contributor Author

This works as expected on my big-endian machine, thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants