-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add obsolete attribute to DisablePrivateReflectionAttribute #49550
Merged
stephentoub
merged 15 commits into
dotnet:main
from
annchous:obsolete-DisablePrivateReflectionAttribute
Mar 17, 2021
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8d3ba91
Add obsolete attribute to DisablePrivateReflectionAttribute
annchous 9c85c63
Attribute added to ref file
annchous 80d431e
fix ref file and attribute
annchous 0ba620f
Add new diagnostic ID
annchous 31532f7
Fix obsolete attribute
annchous 47d3f99
Fix obsolete attribute in ref file
annchous 420faa7
Add new obsoletion ID to documentation
annchous 1ab8ff0
Removed all references of DisablePrivateReflection in src/coreclr
annchous 5b44c5e
Fixed error message of obsoletion
annchous ee26ac4
Fixed documentation
annchous b7a8c48
Removed reference of DisablePrivateReflection
annchous fd6c291
Add NoWarn for new obsoletion ID
annchous d5fb2ba
Add pragma to tests
annchous 1c9f137
Fix error message of new obsoletion
annchous f0740ff
Fix new obsoletion description in documentation
annchous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attribute still has effect in a few corner cases in CoreCLR. Search for
DisablePrivateReflection
undersrc\coreclr
and delete everything found.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we may want to say
.NET 6.0+
in the error message.