-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AndroidCrypto] Implement DSA import/export and signing/verification. #49153
Conversation
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis PR gets all of the DSA tests in System.Security.Cryptography.Algorithms.Tests passing.
|
@@ -137,7 +137,7 @@ public static void ImportRoundTrip(bool includePrivate) | |||
[InlineData(true)] | |||
public static void ExportAfterDispose(bool importKey) | |||
{ | |||
DSA key = importKey ? DSAFactory.Create(DSATestData.GetDSA1024Params()) : DSAFactory.Create(512); | |||
DSA key = importKey ? DSAFactory.Create(DSATestData.GetDSA1024Params()) : DSAFactory.Create(1024); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped this up to 1024 since using an auto-generated 1024-bit key should still validate the test and Android doesn't support keys smaller than 1024.
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_dsa.h
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
…id.cs Co-authored-by: Jeremy Barton <[email protected]>
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_dsa.c
Outdated
Show resolved
Hide resolved
...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/DSA.Create.Android.cs
Outdated
Show resolved
Hide resolved
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Show resolved
Hide resolved
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Outdated
Show resolved
Hide resolved
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Outdated
Show resolved
Hide resolved
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Show resolved
Hide resolved
Any more feedback on this PR? |
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
cc: @dotnet/runtime-infrastructure for windows x86 dev-innerloop timeout. It looks like one of the steps in the installer build took 12 minutes. Maybe antivirus spent a lot of time examining the files? |
This PR gets all of the DSA tests in System.Security.Cryptography.Algorithms.Tests passing.