[AndroidCrypto] Implement DSA import/export and signing/verification. #49153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
requested review from
steveisok,
bartonjs,
AaronRobinsonMSFT and
elinor-fung
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis PR gets all of the DSA tests in System.Security.Cryptography.Algorithms.Tests passing.
|
jkoritzinsky
commented
Mar 4, 2021
| @@ -137,7 +137,7 @@ public static void ImportRoundTrip(bool includePrivate) | |||
| [InlineData(true)] | |||
| public static void ExportAfterDispose(bool importKey) | |||
| { | |||
| DSA key = importKey ? DSAFactory.Create(DSATestData.GetDSA1024Params()) : DSAFactory.Create(512); | |||
| DSA key = importKey ? DSAFactory.Create(DSATestData.GetDSA1024Params()) : DSAFactory.Create(1024); | |||
There was a problem hiding this comment.
I bumped this up to 1024 since using an auto-generated 1024-bit key should still validate the test and Android doesn't support keys smaller than 1024.
vcsjones
reviewed
Mar 4, 2021
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 4, 2021
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 4, 2021
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 4, 2021
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 4, 2021
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_dsa.h
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 4, 2021
src/libraries/Common/src/System/Security/Cryptography/DSAAndroid.cs
Outdated
Show resolved
Hide resolved
…id.cs Co-authored-by: Jeremy Barton <[email protected]>
elinor-fung
reviewed
Mar 5, 2021
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_dsa.c
Outdated
Show resolved
Hide resolved
...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/DSA.Create.Android.cs
Outdated
Show resolved
Hide resolved
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Show resolved
Hide resolved
bartonjs
reviewed
Mar 5, 2021
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 5, 2021
...rc/Interop/Android/System.Security.Cryptography.Native.Android/Interop.EcDsa.ImportExport.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 5, 2021
...raries/Common/src/Interop/Android/System.Security.Cryptography.Native.Android/Interop.Dsa.cs
Show resolved
Hide resolved
|
Any more feedback on this PR? |
bartonjs
approved these changes
Mar 5, 2021
|
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
cc: @dotnet/runtime-infrastructure for windows x86 dev-innerloop timeout. It looks like one of the steps in the installer build took 12 minutes. Maybe antivirus spent a lot of time examining the files? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets all of the DSA tests in System.Security.Cryptography.Algorithms.Tests passing.