-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate, expand, and clean up some HTTP proxy tests #48687
Conversation
…ientHandlerTest.Proxy.cs
… a CredentialCache
Tagging subscribers to this area: @dotnet/ncl Issue DetailsMove some proxy-related tests into HttpClientHandlerTest.Proxy.cs Contributes to #30205
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Seems like some platforms do not like the change:
|
Strange. These are caused by using "is not null". We definitely use this in the product, so I'm not sure why it would be disallowed in tests, and apparently only on certain platforms... @stephentoub any idea what's going on here? Regardless, I'll fix it. |
Whatever project/target this is set in is probably being compiled with LangVersion set to a version prior to |
Line 6 in 57acd56
|
Thanks. Is that intentional/necessary? |
I don't know why it's needed. We generally set LangVersion to preview or latest for the whole repo. It was added here: I'd say just delete it and see what if anything fails to compile. |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
@wfurt can you review when you have a minute? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Move some proxy-related tests into HttpClientHandlerTest.Proxy.cs
Expand some tests to include more variations and be consistent about the variations they test
Re-enable a proxy test that's been disabled for a while and is hopefully no longer flaky
Remove checks for HTTP3 as they are not needed because this class is not included in HTTP3 tests
Various minor cleanup
Contributes to #30205