Change Annotations #48536
Merged
Change Annotations #48536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetMember/GetMembers for the list of DynamicallyAccessedMemberTypes that actually keeps - Remove UnconditionalSupressMessage for new recognized intrinsics - Remove DynamicallyAccessedMemberTypes.NonPublicProperties from ColorTable.FillWithProperties
|
Tagging subscribers to this area: @safern, @tarekgh Issue Details
Fixes #48367
|
eerhardt
reviewed
Feb 22, 2021
src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs
Outdated
Show resolved
Hide resolved
added 2 commits
February 23, 2021 12:54
Fix ApiCompat issues
eerhardt
reviewed
Feb 24, 2021
eerhardt
reviewed
Feb 24, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/IReflect.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 24, 2021
src/libraries/System.Reflection.Emit/ref/System.Reflection.Emit.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 24, 2021
eerhardt
reviewed
Feb 26, 2021
| @@ -583,5 +567,14 @@ public static Binder DefaultBinder | |||
| public static readonly MemberFilter FilterNameIgnoreCase = (m, c) => FilterNameImpl(m, c!, StringComparison.OrdinalIgnoreCase); | |||
|
|
|||
| private const BindingFlags DefaultLookup = BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public; | |||
| // DynamicallyAccessedMemberTypes.All keeps more data than what a member can use, it will keep info about | |||
| // interfaces and nested types as a whole (the nested type and all its members). Instead this GetAllMembers | |||
There was a problem hiding this comment.
(nit) it might also be good to add a blurb about private base members as well, since that is a key difference.
eerhardt
approved these changes
Feb 26, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48367
Fixes dotnet/linker#1724