-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Annotations #48536
Change Annotations #48536
Conversation
GetMember/GetMembers for the list of DynamicallyAccessedMemberTypes that actually keeps - Remove UnconditionalSupressMessage for new recognized intrinsics - Remove DynamicallyAccessedMemberTypes.NonPublicProperties from ColorTable.FillWithProperties
Tagging subscribers to this area: @safern, @tarekgh Issue Details
Fixes #48367
|
src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs
Outdated
Show resolved
Hide resolved
Fix ApiCompat issues
src/libraries/System.Private.CoreLib/src/System/Reflection/IReflect.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.Emit/ref/System.Reflection.Emit.cs
Outdated
Show resolved
Hide resolved
@@ -583,5 +567,14 @@ public static Binder DefaultBinder | |||
public static readonly MemberFilter FilterNameIgnoreCase = (m, c) => FilterNameImpl(m, c!, StringComparison.OrdinalIgnoreCase); | |||
|
|||
private const BindingFlags DefaultLookup = BindingFlags.Instance | BindingFlags.Static | BindingFlags.Public; | |||
// DynamicallyAccessedMemberTypes.All keeps more data than what a member can use, it will keep info about | |||
// interfaces and nested types as a whole (the nested type and all its members). Instead this GetAllMembers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) it might also be good to add a blurb about private base members as well, since that is a key difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making this area better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #48367
Fixes dotnet/linker#1724