Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Activity Trace Id Custom Generation Support #48138

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Add Activity Trace Id Custom Generation Support #48138

merged 3 commits into from
Feb 12, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Feb 11, 2021

Fixes #46704

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 11, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #46704

Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Tracing, new-api-needs-documentation
Milestone: -

@tarekgh tarekgh requested a review from noahfalk February 11, 2021 00:35
@tarekgh tarekgh added this to the 6.0.0 milestone Feb 11, 2021
noahfalk
noahfalk approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggested a few adjustments in the comment text. Thanks @tarekgh!

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Outdated Show resolved Hide resolved
@tarekgh
Copy link
Member Author

tarekgh commented Feb 11, 2021 •
edited
Loading

The CI Windows x64 Release leg failure is tracked by #48169

@tarekgh
Copy link
Member Author

tarekgh commented Feb 12, 2021

Created the issue #48198 to track runtime (Libraries Test Run release coreclr windows x64 Debug) failure.

@tarekgh tarekgh merged commit b2adfd7 into dotnet:master Feb 12, 2021
@tarekgh tarekgh deleted the SupportActivityTraceIdCustomGeneration branch February 12, 2021 00:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.Activity new-api-needs-documentation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Support customized Activity trace id generation
3 participants
@tarekgh @stephentoub @noahfalk