Optimize Matrix.Elements #47932
Merged
Optimize Matrix.Elements #47932
+44
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just pin the array. There is no need to allocate native memory and copy.
|
Tagging subscribers to this area: @safern, @tannergooding Issue DetailsJust pin the array. There is no need to allocate native memory and copy.
|
stephentoub
reviewed
Feb 5, 2021
src/libraries/System.Drawing.Common/src/System/Drawing/Drawing2D/Matrix.cs
Show resolved
Hide resolved
src/libraries/System.Drawing.Common/src/System/Drawing/Drawing2D/Matrix.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Feb 6, 2021
src/libraries/System.Drawing.Common/src/System/Drawing/Icon.Windows.cs
Outdated
Show resolved
Hide resolved
safern
approved these changes
Feb 6, 2021
stephentoub
reviewed
Feb 7, 2021
| copy.X += (int)graphics.Transform.OffsetX; | ||
| copy.Y += (int)graphics.Transform.OffsetY; | ||
|
|
||
| using Matrix transform = graphics.Transform; |
There was a problem hiding this comment.
Wow, a property that allocates and returns a new finalizable object on every access... awesome ;-)
There was a problem hiding this comment.
I've got a proposal up to help address this, um, suboptimal pattern: #47940
stephentoub
reviewed
Feb 7, 2021
stephentoub
approved these changes
Feb 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pin the array. There is no need to allocate native memory and copy.