Fix number parsing with negative sign

[tarekgh]

Fixes #47524

This change allow parsing negative numbers written with the hyphen character - when using cultures with negative sign not hyphen but it is one of the alternative Unicode minus sign characters.
I have done some basic perf testing with this change and didn't notice any noticeable change.

[ghost]

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #47524

This change allow parsing negative numbers written with the hyphen character - when using cultures with negative sign not hyphen but it is one of the alternative Unicode minus sign characters.
I have done some basic perf testing with this change and didn't notice any noticeable change.

Author:	tarekgh
Assignees:	-
Labels:	area-System.Globalization
Milestone:	-

[GrabYourPitchforks]

Do we also need to update runtime/src/libraries/Common/src/System/Globalization/FormatProvider.Number.cs? There are some references to NumberFormatInfo.NegativeSign in that file.

Other files to inspect:

• System/Windows/Forms/NumericUpDown.cs
• System/Text/Json/Serialization/Converters/Value/EnumConverter.cs

(That latter file stores current culture data into a static field, which is probably a bug.)

[tarekgh]

@GrabYourPitchforks

Do we also need to update runtime/src/libraries/Common/src/System/Globalization/FormatProvider.Number.cs?

Yes, you are right. I'll fix this one too. I am not sure why we have parsing code in multiple places.

System/Windows/Forms/NumericUpDown.cs

This file is in WinForms repo and not runtime. I looked at it and they have keyInput.Equals(negativeSign) if they need this work correctly they can convert it to keyInput.Equals(negativeSign, StringComparison.CurrentCulture).

System/Text/Json/Serialization/Converters/Value/EnumConverter.cs

This should be fine because they are testing with the linguistic StartsWith which should work.

[tarekgh]

Any other comments here?

[GrabYourPitchforks]

LGTM. Though I'd still like to see a comment on the switch statement saying "here's where we pulled this list of values from."

[GrabYourPitchforks]

@tarekgh I sent an IM to you on Teams asking for clarification on something. Check that if you have a sec before merging.

[danmoseley]

Do we need to create a followup issue track reducing duplication you discovered here?

[tarekgh]

I just discovered there some changes I didn't submit yet :-( so I am going to submit it soon.

[GrabYourPitchforks]

@danmosemsft There's a tracking issue at #28657.

[tarekgh]

Now all changes is submitted.

[GrabYourPitchforks]

Thanks for adding the comments and tests! 👍