Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Activity.GetTagItem #47443

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Implement Activity.GetTagItem #47443

merged 2 commits into from
Jan 27, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 26, 2021

Fixes #39866

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh
Copy link
Member Author

tarekgh commented Jan 27, 2021

The failures here is unrelated and tracked by #47374

@tarekgh tarekgh merged commit 19e825c into dotnet:master Jan 27, 2021
@tarekgh tarekgh deleted the GetTagItem branch January 27, 2021 01:14
@ghost ghost locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Activity.GetTagItem
3 participants