Add new Task-based socket methods for UDP and reimplement existing ones using SocketAsyncEventArgs #47229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs # src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketTaskExtensions.cs
antonfirsov
changed the title
|
@geoffkizer can you please take another look at the tests, and give a final approval if things look OK? I had to delete my SendTo cancellation test, since it looks like there is no reliable way to enforce I opened a bunch of issues for the corner cases discovered, and referenced them in my test workarounds. Most of them are minor compatibility cases, except the first one, which is actually concerning: #47342, #47335, #47469, #47425 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
geoffkizer
reviewed
Jan 26, 2021
src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs
Outdated
Show resolved
Hide resolved
geoffkizer
approved these changes
Jan 26, 2021
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41502, but does not change the existing APM methods, I plan to do it in a follow-up PR.
The PR is built on @geoffkizer's branch, almost all product code changes were written by him, I just added a bunch of tests, fixed an issue with Windows cancellation (4e4add1), and moved extension methods to the
Socketclass as per #43901.As such, the product code needs a third pair of yes to review. @stephentoub maybe?