Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CryptoStream Memory-based ReadAsync/WriteAsync overrides #47207

Merged
merged 14 commits into from
Feb 26, 2021
Merged

CryptoStream Memory-based ReadAsync/WriteAsync overrides #47207

merged 14 commits into from
Feb 26, 2021

Commits on Jan 19, 2021

  1. Memorify CryptoStream.ReadAsync

    @NewellClark
    NewellClark committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    c9e983f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Memorify CryptoStream.WriteAsync

    @NewellClark
    NewellClark committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    b8b0bef View commit details
    Browse the repository at this point in the history

  2. Zeroed memory in rented array

    @NewellClark
    NewellClark committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    011bfd6 View commit details
    Browse the repository at this point in the history

  3. Update src/libraries/System.Security.Cryptography.Primitives/src/Syst… 

    …em/Security/Cryptography/CryptoStream.cs


Use explicit type

Co-authored-by: Stephen Toub <[email protected]>
    @NewellClark @stephentoub
    NewellClark and stephentoub authored Jan 20, 2021
    Configuration menu
    Copy the full SHA
    88f61f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Fix exception behavior 

    Unintentional breaking change with exceptions that was blocking CI. Note to self: remember to rebuild before running unit tests.
    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    259a3b3 View commit details
    Browse the repository at this point in the history

  2. [no merge] Pinned array, used finally block 

    Still need to override CopyTo/CopyToAsync. I just want to make sure that CI will pass with changes so far.
    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c31f85f View commit details
    Browse the repository at this point in the history

  3. Added CopyTo/CopyToAsync overrides 

    - Applied fixes suggested by @bartonjs
- Added overrides for CopyTo/CopyToAsync to ensure any temporary buffers are properly cleared.
    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5eebaf6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'dotnet/master' into memorify-CryptoStream

    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5a81527 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'dotnet/master' into memorify-CryptoStream

    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    4046040 View commit details
    Browse the repository at this point in the history

  6. Use fully-qualified name in ref

    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    813a1c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Merge remote-tracking branch 'dotnet/master' into memorify-CryptoStream

    @NewellClark
    NewellClark committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    bdf4778 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Update src/libraries/System.Security.Cryptography.Primitives/src/Syst… 

    …em/Security/Cryptography/CryptoStream.cs
    @bartonjs
    bartonjs authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9b08e51 View commit details
    Browse the repository at this point in the history

  2. Undo bad edit

    @bartonjs
    bartonjs authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    79b086e View commit details
    Browse the repository at this point in the history

  3. Update src/libraries/System.Security.Cryptography.Primitives/ref/Syst… 

    …em.Security.Cryptography.Primitives.cs
    @bartonjs
    bartonjs authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    f506f37 View commit details
    Browse the repository at this point in the history