Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Delegate.CreateDelegate trimming safe #47017

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Make Delegate.CreateDelegate trimming safe #47017

merged 2 commits into from
Jan 20, 2021

Commits on Jan 14, 2021

  1. Make Delegate.CreateDelegate trimming safe 

    The underlying code will find non-public methods on base types, but the current annotation won't preserve these methods. Use All annotation on the Type to ensure they are preserved.

Fix dotnet#46857
    @eerhardt
    eerhardt committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    ef3d0fd View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Respond to PR feedback. 

    * Add comments around the use of 'All'
* Add a trimming test
    @eerhardt
    eerhardt committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    96ce9f5 View commit details
    Browse the repository at this point in the history