Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SocketsHttpHandler.ConnectCallback for sync requests #45300

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Allow SocketsHttpHandler.ConnectCallback for sync requests #45300

merged 1 commit into from
Nov 30, 2020

Commits on Nov 28, 2020

  1. Allow SocketsHttpHandler.ConnectCallback for sync requests 

    HTTP/1.1 support with sync requests currently doesn't work when a ConnectCallback is specified, even though a developer who wanted to make synchronous requests could provide a synchronously-completing callback.

This also consolidates the connect logic across sync/async, avoids an extra delegate, etc.
    @stephentoub
    stephentoub committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    2751537 View commit details
    Browse the repository at this point in the history