Add support for stack walks on wasm for the reflection methods which need them. #45076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
CoffeeFlux,
lambdageek and
SamMonoRT
as code owners
|
Tagging subscribers to this area: |
lambdageek
reviewed
Nov 23, 2020
| @@ -3489,6 +3489,22 @@ method_needs_stack_walk (MonoCompile *cfg, MonoMethod *cmethod) | |||
| if (!strcmp (cmethod->name, "GetType")) | |||
| return TRUE; | |||
| } | |||
|
|
|||
| #if defined(ENABLE_NETCORE) | |||
There was a problem hiding this comment.
Do we want to do this everywhere or just on wasm?
There was a problem hiding this comment.
Everywhere really, other platforms need a bit of support as well, just to turn off tail calls.
lambdageek
approved these changes
Nov 23, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44269.