Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LINQ usage from EnvironmentVariablesConfigurationProvider #44923

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

stephentoub
Copy link
Member

With the env vars on my machine...

Before:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Load 54.73 us 0.355 us 0.296 us 8.7280 1.4648 - 53.48 KB

After:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Load 46.05 us 0.886 us 0.870 us 7.2021 1.1597 - 44.26 KB

Contributes to #44598

@stephentoub stephentoub added this to the 6.0.0 milestone Nov 19, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

With the env vars on my machine...

Before:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Load 54.73 us 0.355 us 0.296 us 8.7280 1.4648 - 53.48 KB

After:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Load 46.05 us 0.886 us 0.870 us 7.2021 1.1597 - 44.26 KB

Contributes to #44598

Author: stephentoub
Assignees: -
Labels:

area-Extensions-Configuration, tenet-performance

Milestone: 6.0.0

@stephentoub stephentoub merged commit 8d38285 into dotnet:master Nov 20, 2020
@stephentoub stephentoub deleted the envconfig branch November 20, 2020 23:57
Emzi0767 added a commit to Emzi0767/dotnet-runtime that referenced this pull request Dec 20, 2020
Emzi0767 pushed a commit to Emzi0767/dotnet-runtime that referenced this pull request Dec 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants