Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run class cctor in RuntimeHelpers.GetUninitializedObject(type). #44898

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Run class cctor in RuntimeHelpers.GetUninitializedObject(type). #44898

merged 3 commits into from
Nov 19, 2020

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Nov 18, 2020

Fixes #44852.

@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

Fixes #44852.
Author: vargaz
Assignees: -
Labels:

area-VM-meta-mono
Milestone: -

@monojenkins monojenkins mentioned this pull request Nov 18, 2020
Merged
@am11
Copy link
Member

am11 commented Nov 18, 2020

Should the mono exclusion be deleted to validate the fix in CI? It's just this line:

runtime/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeHelpersTests.cs

Line 280 in 38259c8

[ActiveIssue("https://github.com/dotnet/runtime/issues/44852", TestRuntimes.Mono)]

@runfoapp runfoapp bot mentioned this pull request Nov 19, 2020
Open
@vargaz vargaz merged commit 3440021 into dotnet:master Nov 19, 2020
@vargaz vargaz deleted the uninit-cctor branch November 19, 2020 22:42
@zwarich zwarich mentioned this pull request Dec 1, 2020
Closed
6 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@thaystg thaystg Awaiting requested review from thaystg

Assignees
No one assigned
Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mono: RuntimeHelpers.GetUninitializedObject doesn't run class ctor
4 participants
@vargaz @am11 @lambdageek @Dotnet-GitSync-Bot