Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy OpenSSL binaries when creating Android apps #44577

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

fanyang-mono
Copy link
Member

This PR could resolve some failures mentioned in #44306

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger
Copy link
Member

None of the runtime tests hit the Crypto APIs so this shouldn't be needed.

@EgorBo
Copy link
Member

EgorBo commented Nov 12, 2020

None of the runtime tests hit the Crypto APIs so this shouldn't be needed.

For some reasons some of them actually tried judging by logs.
E.g. there is a Marvin hash implementation which is calling OpenSSL's getrandombytes, and that Marvin (different from what is used inside SPC) is used in some XML-related code, something like this.

@akoeplinger
Copy link
Member

@EgorBo that would need to be a recent change then since the runtime tests were passing before and without openssl that would not be possible right?

I'm fine with getting this in btw if we understand that it's necessary.

@akoeplinger akoeplinger merged commit 5c3e0b1 into dotnet:master Nov 12, 2020
@fanyang-mono
Copy link
Member Author

@EgorBo that would need to be a recent change then since the runtime tests were passing before and without openssl that would not be possible right?

I'm fine with getting this in btw if we understand that it's necessary.

@akoeplinger I had the same question. Why they used to pass without this change. But want to give it a try with this change to see if it would fix anything.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
@fanyang-mono fanyang-mono deleted the android_app_fix branch May 27, 2021 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants