-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing XML docs to System.Security.* #44461
Conversation
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley Issue meta data
|
f3a2226
to
f32b1fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the full language review here to avoid doing it later.
...stem.Security.Cryptography.Algorithms/src/System/Security/Cryptography/Rfc2898DeriveBytes.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Sanchez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there was also an exception that needed to be documented. I don't think I missed any others in the APIs you are documenting in this PR, but can you please double check?
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Show resolved
Hide resolved
…urity/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs Co-authored-by: Carlos Sanchez <[email protected]>
This looks redundant to the docs already on dotnet-api-docs... why do we have a one off effort for this one, instead of waiting for the bulk import? |
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Barton <[email protected]>
...ecurity.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Outdated
Show resolved
Hide resolved
…urity/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
Contributes to: #43861
Adds missing XML docs to System.Security.*
Complemented by dotnet-api-docs PR: dotnet/dotnet-api-docs#5106