Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix illumos managed build #44386

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Fix illumos managed build #44386

merged 4 commits into from
Nov 18, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 8, 2020 •
edited
Loading

  • Implement Enviornment.WorkingSet for SunOS.
    • Difference between Linux and SunOS procfs is that files in latter
      contain binary data, so we need read(2) and cast into corresponding
      struct. Redeclaring system structs in managed code is not ideal, as
      they do change across the major versions of OS, which inevitably
      requires recompilation of binaries and replicating them in C# as is
      means additional/unnecessary maintenance of code.
  • Fix CA1823 (unused private field) in NetworkChange partial for
    UnknownUnix.
  • Use official casing illumos in MSBuild property names (as done for
    iOS).
  • Fix Solaris version in test with SDK's PlatformDetection.
    • only major version is needed.

@am11 am11 marked this pull request as ready for review November 8, 2020 15:30
@am11 am11 requested a review from marek-safar as a code owner November 8, 2020 15:30
@am11
Copy link
Member Author

am11 commented Nov 8, 2020 •
edited
Loading

cc @stephentoub
First commit throws PNSE from WorkingSet, second commit implements the API. I can split the PRs, if it's preferred. :)

Downstream CI: build logs | build artifacts - tested .NET 6 assemblies on Open Indiana.

am11 added 2 commits November 9, 2020 05:28
@am11
Fix illumos managed build
eb757ac 
* Fix CA1823 (unused private field) in `NetworkChange` partial for
  `UnknownUnix`.
* Use official casing `illumos` in MSBuild property names (as done for
  iOS).
* Fix Solaris version in test with SDK's PlatformDetection.
  * only major version is needed.
@am11
Implement Enviornment.WorkingSet for SunOS
02d0b7e 
Difference between Linux and SunOS procfs is that files in latter
contain binary data, so we need `read(2)` and cast into corresponding
struct. Redeclaring system structs in managed code is not ideal, as
they do change across the major versions of OS, which inevitably
requires recompilation of binaries and replicating them in C# as is
means additional/unnecessary maintenance of code.
@am11 am11 requested a review from stephentoub November 12, 2020 15:48
@am11
Copy link
Member Author

am11 commented Nov 16, 2020

@stephentoub, I have addressed the comments and resolved a merge conflict. Could you please give another pass?

stephentoub
stephentoub approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub merged commit cb3ecbb into dotnet:master Nov 18, 2020
@am11 am11 deleted the feature/sunos/e2e-build branch November 18, 2020 23:50
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @stephentoub @Dotnet-GitSync-Bot