Remove stale TODO-NULLABLE comments from code #44136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
todonullable
branch
from
50f7789 to
92a03cf
Compare
stephentoub
force-pushed
the
todonullable
branch
from
92a03cf to
e234898
Compare
krwq
reviewed
Nov 2, 2020
| throw new Exception(SR.Diagnostic_InternalExceptionMessage); | ||
| } | ||
| return MemberType.GetHashCode() ^ _accessors[0]!.GetHashCode(); // TODO-NULLABLE: Indexer nullability tracked (https://github.com/dotnet/roslyn/issues/34644) | ||
| return MemberType.GetHashCode() ^ accessor.GetHashCode(); |
There was a problem hiding this comment.
nit: should this use hash code combiner? cc: @GrabYourPitchforks
There was a problem hiding this comment.
HashCodeCombiner is good for things that don't have a great distribution already. One example is a record type where the user is responsible for providing most of the fields, which is likely to see many of the values clustered around the same set of hash codes. Since this hash code calculation routine is using reflection and other runtime objects, there's not as much concern about clustering, since these objects already have good distribution.
krwq
reviewed
Nov 2, 2020
src/libraries/System.Drawing.Common/src/System/Drawing/Printing/PrintingServices.Unix.cs
Show resolved
Hide resolved
krwq
approved these changes
Nov 2, 2020
safern
approved these changes
Nov 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @krwq, @jeffhandley