Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] [browser][crypto] Remove restraining not supported attribute Primitives #43441

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 15, 2020

Backport of #43387 to release/5.0

/cc @kjpou1

issue: #43380

Customer Impact

The modules included within the System.Security.Cryptography.Primitives module should still be available for use outside of browser os.

The classes and enums included in this module do not provide an implementation and instead are used and implemented from and across the other System.Security.Cryptography.XXXX modules.

Testing

Unit and Functional tests are included.

Risk

Low risk as the attribute was removed thus loosening up the warnings produced.

- The modules included within the System.Security.Cryptography.Primitives module should still be available for use outside of browser os.
@lewing lewing added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 15, 2020
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in tactics email.

@marek-safar marek-safar merged commit cf258a1 into release/5.0 Oct 19, 2020
@marek-safar marek-safar deleted the backport/pr-43387-to-release/5.0 branch October 19, 2020 17:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants