Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataContractSerialization ILLink.Suppressions.xml #42930

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

eerhardt
Copy link
Member

Changes #40691 and #42824 conflicted. One added a new ILLink suppress warnings file, while the other added more warnings. This causes the build to break.

The fix is to regenerate the suppressions file with the latest code.

Fix #42926

Changes dotnet#40691 and dotnet#42824 conflicted. One added a new ILLink suppress warnings file, while the other added more warnings. This causes the build to break.

The fix is to regenerate the suppressions file with the latest code.

Fix dotnet#42926
@eerhardt
Copy link
Member Author

eerhardt commented Oct 1, 2020

Test failure is:

System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_ConnectCallback_Http2.ConnectCallback_UseUnixDomainSocket_Success(useSsl: False) [FAIL]
      System.OperationCanceledException : The operation was canceled.
      Stack Trace:
        /_/src/libraries/System.Private.CoreLib/src/System/Threading/CancellationToken.cs(354,0): at System.Threading.CancellationToken.ThrowOperationCanceledException()
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs(914,0): at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
        /_/src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs(883,0): at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(124,0): at System.Net.Test.Common.Http2LoopbackConnection.FillBufferAsync(Memory`1 buffer, CancellationToken cancellationToken)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(158,0): at System.Net.Test.Common.Http2LoopbackConnection.ReadFrameAsync(CancellationToken cancellationToken)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(182,0): at System.Net.Test.Common.Http2LoopbackConnection.ReadFrameAsync(CancellationToken cancellationToken)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(148,0): at System.Net.Test.Common.Http2LoopbackConnection.ReadFrameAsync(TimeSpan timeout)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(290,0): at System.Net.Test.Common.Http2LoopbackConnection.WaitForClientDisconnectAsync(Boolean ignoreUnexpectedFrames)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(321,0): at System.Net.Test.Common.Http2LoopbackConnection.WaitForConnectionShutdownAsync(Boolean ignoreUnexpectedFrames)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(331,0): at System.Net.Test.Common.Http2LoopbackConnection.ShutdownIgnoringErrorsAsync(Int32 lastStreamId, ProtocolErrors errorCode)
        /_/src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs(795,0): at System.Net.Test.Common.Http2LoopbackConnection.Dispose()
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs(2460,0): at System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_ConnectCallback.ConnectCallback_UseUnixDomainSocket_Success(Boolean useSsl)

The other 2 legs hung.

This change only affected building - not tests. Merging to unblock the CI break.

@eerhardt eerhardt merged commit ee993b4 into dotnet:master Oct 1, 2020
@eerhardt eerhardt deleted the FixILLinkWarningsSerialization branch October 1, 2020 01:49
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IL Link warning failures in System.Private.DataContractSerialization breaking the build
3 participants