Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Improving logging control for tests #42175

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

radical
Copy link
Member

@radical radical commented Sep 13, 2020

  • replace CWLs with log messages

  • Fix use of loggerFactory, and logger to correctly configure them, and
    allow being controlled via appsettings.json

  • Also, add default settings for proxy also, just an example:

     "LogLevel": {
       "Default": "Error",
       "Microsoft": "Warning",
       "Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Information",
       "Microsoft.WebAssembly.Diagnostics.DevToolsProxy": "Information",
       "DebuggerTests.Inspector": "Information"
    }

Eg. to see trace messages (eg. protocol chat) for the test proxy:
"Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Trace"

@ghost
Copy link

ghost commented Sep 13, 2020

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@radical radical added the arch-wasm WebAssembly architecture label Sep 14, 2020
@radical
Copy link
Member Author

radical commented Sep 14, 2020

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

- replace CWLs with log messages
- Fix use of loggerFactory, and logger to correctly configure them, and
allow being controlled via appsettings.json

- Also, add default settings for proxy also, just an example:

```
     "LogLevel": {
       "Default": "Error",
       "Microsoft": "Warning",
       "Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Information",
       "Microsoft.WebAssembly.Diagnostics.DevToolsProxy": "Information",
       "DebuggerTests.Inspector": "Information"
    }
```

Eg. to see trace messages (eg. protocol chat) for the test proxy:
    `"Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Trace"`
@radical
Copy link
Member Author

radical commented Sep 16, 2020

@lewing @thaystg any thoughts on this?

Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lewing lewing merged commit db6c320 into dotnet:master Sep 17, 2020
@radical radical deleted the wasm-log-control branch September 18, 2020 22:06
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants