-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Improving logging control for tests #42175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @thaystg |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
- replace CWLs with log messages - Fix use of loggerFactory, and logger to correctly configure them, and allow being controlled via appsettings.json - Also, add default settings for proxy also, just an example: ``` "LogLevel": { "Default": "Error", "Microsoft": "Warning", "Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Information", "Microsoft.WebAssembly.Diagnostics.DevToolsProxy": "Information", "DebuggerTests.Inspector": "Information" } ``` Eg. to see trace messages (eg. protocol chat) for the test proxy: `"Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Trace"`
radical
force-pushed
the
wasm-log-control
branch
from
September 15, 2020 19:38
b99cb9f
to
f03dd52
Compare
thaystg
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
lewing
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace CWLs with log messages
Fix use of loggerFactory, and logger to correctly configure them, and
allow being controlled via appsettings.json
Also, add default settings for proxy also, just an example:
Eg. to see trace messages (eg. protocol chat) for the test proxy:
"Microsoft.WebAssembly.Diagnostics.TestHarnessProxy": "Trace"