-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily block out UnmanagedCallersOnlyTest in Pri1 runs #42169
Conversation
The intent of this PR is to provide a temporary workaround before #42146 is merged in. I don't have the latest info on the development on 42146 so I'm just pulling in the proximate stakeholders to cooperate in making a call on which change should go in first. The idea is that, if 42146 is about to be merged in [very] soon, this change doesn't make sense and would only cause extra churn; but prolonged wait in the broken state is detrimental to all parties. |
The test is failing with the current PR state, so it needs some work before it gets merged. |
Hello @jkotas! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 62 seconds. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting way to disable the build. Isn't the "normal" way to use <DisableProjectBuild>true</DisableProjectBuild>
?
Anyway, LGTM if the outerloop job works
I just merged the fixed test. This is no longer needed. |
Works around: #42168
/cc: @dotnet/runtime-infrastructure