Condition VS.Redist.* to PostBuildSign #42129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Sep 11, 2020
|
dotnet/runtime master still hasn't moved to publishing v3. Only the release/5.0-rc2 branch has moved. @epananth is working on fixing this. Does that impact the VS NuGet package publishing in the staging pipeline? |
|
Good catch! I've been having issues creating this PR and for some reason it targeted master when the intention was to target release/5.0-rc2 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've enabled VS.Redist.* publishing on the staging pipeline so we shouldn't need to do this during builds. For now, we'll condition it to happen when PostBuildSign == false.
fyi @chcosta @mmitche