PhysicalFileProvider and PhysicalFilesWatcher should implement IDisposable correctly #41918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Provider and PhysicalFilesWatcher
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @maryamariyan |
jkotas
removed
the
area-CodeGen-coreclr
maryamariyan
approved these changes
Sep 8, 2020
|
Can you also remove the finalizers? Since these classes don't use native resources, they shouldn't have finalizers.
|
eerhardt
reviewed
Sep 9, 2020
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs
Outdated
Show resolved
Hide resolved
Marusyk
force-pushed
the
rmaruyk/41705
branch
from
8e7ec12
to
2945fe0
Compare
ericstj
reviewed
Sep 11, 2020
| public void Dispose() | ||
| { | ||
| Dispose(true); | ||
| GC.SuppressFinalize(this); |
There was a problem hiding this comment.
GC.SuppressFinalize(this); is not necessary on types that don't have finalizers. You removed the finalizer below.
There was a problem hiding this comment.
This was discussed in #41918 (comment)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in implementation of the IDisposable pattern for PhysicalFileProvider and PhysicalFilesWatcher
Fixes #41705
Please review
Thank you in advance