Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Fix tailcall regression with compiled F# #41331

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 25, 2020

Backport of #41206 to release/5.0

/cc @jkotas

Customer Impact

Regression from 3.0. FSharp programs may hit stack overflow due to this bug.

Testing

Targeted test + jitstress and libraries jitstress runs

Risk

jkotas and others added 2 commits August 25, 2020 14:34
This change skips instantiating stubs for direct tailcalls and instead passes the inst argument directly to the target method.

Fixes #40864
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 25, 2020
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a CR.

@jeffschwMSFT
Copy link
Member

Approved, please merge.

@jkotas
Copy link
Member

jkotas commented Aug 25, 2020

Test failure is known issue #40916

@jkotas jkotas merged commit 99efd7e into release/5.0 Aug 25, 2020
@jkotas jkotas deleted the backport/pr-41206-to-release/5.0 branch August 25, 2020 22:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants