[release/5.0] Move Editor Attribute to S.CM.Primitives and apply to types that had it in netfx #41289
Conversation
…it in netfx (dotnet#41145) * Move EditorAttribute to System.ComponentModel.Primitives * Add EditorAttribute to types that had it in netfx and fix some DesignerSerializableAttributes * PR Feedback * PR Feedback
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Can you please add a quick template? @DustinCampbell @RussKie this was done in master. Can you confirm that a port to 5.0 is important to Winforms? The relevant bar would be " Blocking key partner scenarios or blocking adoption " |
Sure. |
|
Updated the description with the template. This PR is a continuation of: |
|
OK approved to merge when green/reviewed. Meets bar "· Blocking key partner scenarios or blocking adoption " |
|
@dotnet/dotnet-winforms for visibility |
|
Failure is Windows7 known issue. |
|
@RussKie if there's a way for you to test with binaries from our repo without waiting for codeflow that would be a bonus, since the bar is about to go up for any changes to this or additional similar changes. |
ghost
locked as resolved and limited conversation to collaborators
Master PR: #41145
This is needed by Winforms.
Description
The winforms designer depends on these attributes to be added to types in order to display the information correctly on the designer.
Customer Impact
Properties and metadata will not be displayed correctly where as in Full Framework it does.
Regression?
From Full Framework, when we ported the types.
Risk
low. This only adds attributes and moves
EditorAttributefromSystem.ComponentModel.TypeConverterstoSystem.ComponentModel.Primitives.Test changes in this PR
Tests for the attributes are still running.
cc: @danmosemsft @RussKie