Remove call to memset in EventPipeBuffer constructor #41194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josalem
approved these changes
Aug 22, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In heavy-write scenarios, it is possible for EventPipeBufferManager::AllocateBufferForThread to block the flushing thread (the thread that is flushing out events out of EventPipeBufferManager to the underlying IPC channel) because they both need to grab the spinlock in EventPipeBufferManager.
From a benchmark I wrote, the
memsethere was found as taking 10% of the thread time for the flushing thread, and I was able to verify that removing this improves overall throughput of Event writes by ~15% in the benchmark program I have with 24 threads writing events as fast as they can.