Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port nullability annotations from System.Private.Xml.Linq to contracts #41086

Merged
4 commits merged into from
Aug 28, 2020
Merged

Port nullability annotations from System.Private.Xml.Linq to contracts #41086

4 commits merged into from
Aug 28, 2020

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 20, 2020 •
edited
Loading

Contributes to #2339

  • Port nullability annotations to System.Xml.XPath.XDocument
  • Port nullability annotations to System.Xml.XDocument

@jozkee jozkee added this to the 5.0.0 milestone Aug 20, 2020
@jozkee jozkee requested review from krwq, buyaa-n and a team August 20, 2020 10:52
@jozkee jozkee self-assigned this Aug 20, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop mentioned this pull request Aug 25, 2020
Merged
14 tasks
krwq
krwq approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple of comments

@krwq
Copy link
Member

krwq commented Aug 28, 2020

please rebase locally (no need to push here) and build to double check nothing breaks

@ghost
Copy link

ghost commented Aug 28, 2020

Hello @jozkee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2af1938 into dotnet:master Aug 28, 2020
carlossanlop pushed a commit to carlossanlop/runtime that referenced this pull request Aug 28, 2020
@jozkee @carlossanlop
Port nullability annotations from System.Private.Xml.Linq to contracts (
181bca2 
dotnet#41086)

* Enable nullability on System.Xml.XPath.XDocument src

* Port nullability annotations to System.Xml.XPath.XDocument

* Port nullability annotations to System.Xml.XDocument

* Add ? to XmlAttribute argument in int? explicit operator
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@jozkee jozkee deleted the nullability_8 branch March 24, 2021 19:35
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

@buyaa-n buyaa-n Awaiting requested review from buyaa-n

Assignees

@jozkee jozkee

Labels
area-System.Xml
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jozkee @krwq