Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging for the browser #41001

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix packaging for the browser #41001

merged 1 commit into from
Aug 19, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Aug 18, 2020

Master PR #40814
Related Issue #40813

@ericstj i think we dont require an approval for this one as it fixes the broken packaging ?

* Fix packaging for the browser

* fix wasm leg

* remove unused resource
@Anipik Anipik requested review from ericstj and safern August 18, 2020 20:41
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@Anipik Anipik changed the title Browser package Fix packaging for the browser Aug 18, 2020
@Anipik Anipik changed the base branch from master to release/5.0 August 18, 2020 20:41
@ericstj
Copy link
Member

ericstj commented Aug 18, 2020

@ericstj i think we dont require an approval for this one as it fixes the broken packaging ?

It's just in M2 approval mode now, so we just need support of me and @danmosemsft. I support this change for RC.

The only product-visible portion of this change is that it adds a PNSE to System.Drawing.Common for browser. Previously if you used this package on browser, you'd compile against a 5.0.0.0 versioned ref, but then get a 4.0.0.1 lib at runtime. Typically our packaging testing infra would have caught this, but it looks like we arent testing for browser. It might make sense to add browser to the set of RIDs we validate for.

@ghost
Copy link

ghost commented Aug 19, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas added the arch-wasm WebAssembly architecture label Aug 19, 2020
@ericstj
Copy link
Member

ericstj commented Aug 19, 2020

I opened a PR to run package tests on browser-wasm here which should catch if we have any other instances of this: #41041

@danmoseley
Copy link
Member

danmoseley commented Aug 19, 2020

pasting from @Anipik

Description

The System.Drawing.Package is missing a ridless configuration, which results in runtime error while consuming the package on a platform which doesnt derive from windows or unix eg browser

Customer Impact

The package will work correctly for browser and non windows now unix platforms.

Regression?

No

Risk

low. This change only affects non-windows non-unix platforms.

Test changes in this PR

Package contains the netcoreapp3.0 configuration. @eric St. John is adding this scenario to package testing as well.

@danmoseley
Copy link
Member

Approved for 5.0

@Anipik Anipik merged commit c2556cc into dotnet:release/5.0 Aug 19, 2020
@Anipik Anipik deleted the browserPackage branch August 19, 2020 23:11
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants