-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packaging for the browser #41001
Conversation
* Fix packaging for the browser * fix wasm leg * remove unused resource
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
It's just in M2 approval mode now, so we just need support of me and @danmosemsft. I support this change for RC. The only product-visible portion of this change is that it adds a PNSE to System.Drawing.Common for browser. Previously if you used this package on browser, you'd compile against a 5.0.0.0 versioned ref, but then get a 4.0.0.1 lib at runtime. Typically our packaging testing infra would have caught this, but it looks like we arent testing for browser. It might make sense to add browser to the set of RIDs we validate for. |
Tagging subscribers to this area: @safern, @ViktorHofer |
I opened a PR to run package tests on browser-wasm here which should catch if we have any other instances of this: #41041 |
pasting from @Anipik DescriptionThe System.Drawing.Package is missing a ridless configuration, which results in runtime error while consuming the package on a platform which doesnt derive from windows or unix eg browser Customer ImpactThe package will work correctly for browser and non windows now unix platforms. Regression?No Risklow. This change only affects non-windows non-unix platforms. Test changes in this PRPackage contains the netcoreapp3.0 configuration. @eric St. John is adding this scenario to package testing as well. |
Approved for 5.0 |
Master PR #40814
Related Issue #40813
@ericstj i think we dont require an approval for this one as it fixes the broken packaging ?