Add parsing of zero port for unknown Uri scheme #40986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
reviewed
Aug 18, 2020
| [Fact] | ||
| public static void ZeroPortIsParsedForBothKnownAndUnknownSchemes() | ||
| { | ||
| Uri.TryCreate("http://example.com:0", UriKind.Absolute, out var uri); |
There was a problem hiding this comment.
Couldn't the test be rather parametrized instead of copying similar block 3 times in a row?
ManickaP
approved these changes
Aug 18, 2020
| Assert.Equal(-1, uri.Port); | ||
| Assert.True(uri.IsDefaultPort); | ||
| Assert.Equal("rtsp://example.com/", uri.ToString()); | ||
| yield return new object[] { "http://example.com:0", 0, false, "http://example.com:0/" }; |
There was a problem hiding this comment.
Is toString same as the uriString except the trailing slash? Do we need the extra parameter?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Miha's suggestion from #37865 (comment)
Fixes #37865