Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Font*, Image* and Margins converters to System.Drawing.Common and apply Unit and Name converter #40825

Merged
merged 4 commits into from
Aug 15, 2020

Conversation

safern
Copy link
Member

@safern safern commented Aug 14, 2020

Fixes: #33061
Fixes: #1011

cc: @DustinCampbell @merriemcgaw @RussKie

@Anipik I'm using the old Generate PNSE exclude API list attribute here.

@ghost
Copy link

ghost commented Aug 14, 2020

Tagging subscribers to this area: @safern, @tannergooding
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@safern
Copy link
Member Author

safern commented Aug 14, 2020

Touching ref assemblies but not adding new API.

@safern safern force-pushed the DrawingConverters branch from 74ab92c to 8554791 Compare August 14, 2020 20:29
@eerhardt
Copy link
Member

<TargetFrameworks>$(NetCoreAppCurrent);netcoreapp3.0</TargetFrameworks>

This project still builds for netcoreapp3.0. Do we need to handle this specially?


Refers to: src/libraries/System.Windows.Extensions/ref/System.Windows.Extensions.csproj:3 in 8554791. [](commit_id = 8554791, deletion_comment = False)

@safern
Copy link
Member Author

safern commented Aug 14, 2020

This project still builds for netcoreapp3.0. Do we need to handle this specially?

Not really because it is not part of the shared framework and the typeforwards are yo System.Drawing.Common which will be in the netcoreapp3.0 implementation as well which is not inbox either, so it will have a PackageReference to System.Drawing.Common so it would work fine.

@safern safern merged commit 1dbdb8b into dotnet:master Aug 15, 2020
@safern safern deleted the DrawingConverters branch August 15, 2020 03:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants