Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of collectible thread statics and GC #40671

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Fix handling of collectible thread statics and GC #40671

merged 2 commits into from
Aug 11, 2020

Commits on Aug 11, 2020

  1. Fix handling of collectible thread statics and GC 

    - NonGc Thread statics helper returns a ByRef, not a pointer for collectible statics
- Tail-call to collectible function can in theory result in GC hole, patch up FramedMethodFrame to report methoddesc when possible
- Add test coverage for collectible statics
- Remove test coverage for converting thread static variable into byref and using that to keep alive the static data as it wasn't fully safe itself
    @davidwrighton
    davidwrighton committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    333e119 View commit details
    Browse the repository at this point in the history

  2. Remove FramedMethodFrame::GcScanRoots 

    - Turns out it wasn't needed
    @davidwrighton
    davidwrighton committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    284d928 View commit details
    Browse the repository at this point in the history