WIP: Initial CoreCLR CI pipeline in the composite repo #4

trylek · 2019-10-31T20:56:36Z

(*) I had to temporarily put back the myget feed because, without it,
we cannot restore Microsoft.DotNet.CoreCLR.TestDependencies;

(*) I temporarily deleted an MSBuild execution in eng/Build.props
that was causing issues – haven’t yet retested after Viktor’s most
recent changes, may be theoretically fixed;

(*) Bumped up MicrosoftPrivateCoreFxNETCoreAppPackageVersion fixes
build of several tests hitting contract mismatches (ARM HW tests,
SuppressGCTransition attributes);

(*) Temporarily removed setup of stress dependencies that hits
trouble when restoring CoreDisTools in the absence of myget feed;

(*) Temporarily downgrated R2RDump to use 00001 version of CoreDisTools
as 00005 is only available on myget – this will likely need resolving
as R2RDump actually needs the newer version (and so does stress
dependency setup);

(*) Most of the remaining issues are just the path tweaks that fall
into four categories - cmd, sh, proj, yml. Based on Viktor's advice
I have a relatively good idea what to do about cmd, sh and proj,
I haven't yet thought about yml (in fact I haven't yet seen the
change in its entirety as a PR to get a better overview).

Thanks

Tomas

P.S. "tiny.yml" is the minimalistic pipeline. Of course I expect
this to be only temporary. I used a second branch with a manual fix
to the pipeline to run Windows_NT instead of OSX so that I didn't
have to create two different pipelines.

This caught my attention because I was messing with `IsBlittableType`. The condition `type.BaseType.IsValueType` is never true because one can never have a type whose base type is a valuetype. I was trying to find out where this code is coming from so I can fix it only to realize it was silently deleted in #23015.

…025.2 (#8668) - System.Windows.Extensions - 5.0.0-alpha.1.19525.2 - System.CodeDom - 5.0.0-alpha.1.19525.2 - System.Configuration.ConfigurationManager - 5.0.0-alpha.1.19525.2 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.2 - Microsoft.NETCore.Targets - 5.0.0-alpha.1.19525.2 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.2 - Microsoft.Win32.Registry - 5.0.0-alpha.1.19525.2 - Microsoft.Win32.SystemEvents - 5.0.0-alpha.1.19525.2 - Microsoft.Windows.Compatibility - 5.0.0-alpha.1.19525.2 - System.Diagnostics.EventLog - 5.0.0-alpha.1.19525.2 - System.Security.AccessControl - 5.0.0-alpha.1.19525.2 - System.Security.Cryptography.Cng - 5.0.0-alpha.1.19525.2 - System.Security.Cryptography.Pkcs - 5.0.0-alpha.1.19525.2 - System.Security.Cryptography.ProtectedData - 5.0.0-alpha.1.19525.2 - System.Security.Cryptography.Xml - 5.0.0-alpha.1.19525.2 - System.Security.Permissions - 5.0.0-alpha.1.19525.2 - System.Security.Principal.Windows - 5.0.0-alpha.1.19525.2 - System.Text.Encodings.Web - 5.0.0-alpha.1.19525.2 - System.Text.Json - 5.0.0-alpha.1.19525.2 - System.Threading.AccessControl - 5.0.0-alpha.1.19525.2 - System.Resources.Extensions - 5.0.0-alpha.1.19525.2 - System.DirectoryServices - 5.0.0-alpha.1.19525.2 - System.Drawing.Common - 5.0.0-alpha.1.19525.2 - System.IO.FileSystem.AccessControl - 5.0.0-alpha.1.19525.2 - System.IO.Packaging - 5.0.0-alpha.1.19525.2

…42127) This reverts commit c57cba7.

Fix getting readonly column metadata

* Get the product build to use the global package cache only. * Move external.csproj out to the tests folder. Fix restore location so external.csproj correctly resolves its nuget-generated props/targets files. * Fix typo. * Fix expected failure case on platforms that don't support PGO/IBC. * Don't error out if optimization data is not supported for the current platform. * Fix casing that was causing the Linux x64 build to fail to find the pgo/ibc packages. * Fix condition. * Pass OS-Arch-Config to external test package restore. * The platform-specific version of Microsoft.NETCore.CoreDisTools is an older version for non-Windows, so hardcode that version in stress_dependencies.csproj

* Packaging for crossgen2 as a framework dependent application. This requires us to manually emit a runtimeconfig json for now, since the build produces a self-contained version of crossgen2. Also includes some minor cleanups to the way we build crossgen2: - Removed from build.proj since we explicitly build it as a self-contained application from build.cmd/build.sh - Removed the output path property from the csproj files. We use an explicit -o argument when publishing to specify the output folder

…025.3 (#8671) - System.Windows.Extensions - 5.0.0-alpha.1.19525.3 - System.CodeDom - 5.0.0-alpha.1.19525.3 - System.Configuration.ConfigurationManager - 5.0.0-alpha.1.19525.3 - Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.3 - Microsoft.NETCore.Targets - 5.0.0-alpha.1.19525.3 - Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.3 - Microsoft.Win32.Registry - 5.0.0-alpha.1.19525.3 - Microsoft.Win32.SystemEvents - 5.0.0-alpha.1.19525.3 - Microsoft.Windows.Compatibility - 5.0.0-alpha.1.19525.3 - System.Diagnostics.EventLog - 5.0.0-alpha.1.19525.3 - System.Security.AccessControl - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Cng - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Pkcs - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.ProtectedData - 5.0.0-alpha.1.19525.3 - System.Security.Cryptography.Xml - 5.0.0-alpha.1.19525.3 - System.Security.Permissions - 5.0.0-alpha.1.19525.3 - System.Security.Principal.Windows - 5.0.0-alpha.1.19525.3 - System.Text.Encodings.Web - 5.0.0-alpha.1.19525.3 - System.Text.Json - 5.0.0-alpha.1.19525.3 - System.Threading.AccessControl - 5.0.0-alpha.1.19525.3 - System.Resources.Extensions - 5.0.0-alpha.1.19525.3 - System.DirectoryServices - 5.0.0-alpha.1.19525.3 - System.Drawing.Common - 5.0.0-alpha.1.19525.3 - System.IO.FileSystem.AccessControl - 5.0.0-alpha.1.19525.3 - System.IO.Packaging - 5.0.0-alpha.1.19525.3

This change modifies R2RDump to use the new System.CommandLine.Experimental module instead of the obsoleted System.CommandLine parser we were using before. Apart from general hygiene w.r.t. using up-to-date components one practical reason for this switch-over is that the old parser is only available on the unreliable myget.org nuget feed we plan to drop as part of our planned repo consolidation. During debugging of the change I noticed a bug in the implementation of the "--verbose" option - it shouldn't be setting EntryPoints, otherwise we actually end up with a super-terse output including just the entry points. I have anecdotally verified that, after fixing this in both the "new" and "old" R2RDump both produce identical output. Thanks Tomas

Signed-off-by: dotnet-bot <[email protected]>

Improved performance of complex casts by caching results of cast analysis. * Easy out for same types. * Introduce cast cache * Use managed heap for the cache * Fixes. Get rid of a fake array typedesc. * TypeDesc conversions caching * Removed NoGC helpers * Cache typedesc conversions * Renamed remaining trivial NoGC casting helpers * Some cleanups. Comments, redundant code. * PR feedback.

* Update dependencies from https://github.com/dotnet/coreclr build 20191025.1 - Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19525.1 - Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19525.1 - Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19525.1 * remove Stopwatch.*.cs from System.Runtime.Extensions build * Disable tests against CoreCLR bug

…aces

…aces Signed-off-by: dotnet-bot <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>

…025.2 (#8673) - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.19525.2

…025.2 (#42137) - Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19525.2 - Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19525.2 - Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19525.2 - Microsoft.DotNet.ApiCompat - 5.0.0-beta.19525.2 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19525.2 - Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19525.2 - Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19525.2 - Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19525.2 - Microsoft.DotNet.GenAPI - 5.0.0-beta.19525.2 - Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19525.2 - Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19525.2 - Microsoft.DotNet.GenFacades - 5.0.0-beta.19525.2

…91026.1 (#8674) - NETStandard.Library - 2.2.0-prerelease.19526.1

* Enable building with clang 9 Update the docker images that we use for building. * Add missing clang9 option to build.sh / build-test.sh * Fix clang version matching and MUSL build * Prevent Clang 9 from optimizing out s_gsCookie write

@drasticactions

`jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread dotnet#1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame dotnet#1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame dotnet#2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame dotnet#3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame dotnet#4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame dotnet#5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame dotnet#6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame dotnet#7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame dotnet#8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame dotnet#9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame dotnet#10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame dotnet#11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame dotnet#12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame dotnet#13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame dotnet#14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame dotnet#15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame dotnet#16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame dotnet#17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame dotnet#18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame dotnet#19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame dotnet#20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame dotnet#21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame dotnet#22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread dotnet#5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame dotnet#1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame dotnet#2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame dotnet#3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame dotnet#4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame dotnet#5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame dotnet#6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame dotnet#7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame dotnet#8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame dotnet#9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame dotnet#10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame dotnet#11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame dotnet#12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame dotnet#13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame dotnet#14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame dotnet#15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615

@drasticactions

…2073) `jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread #1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame #1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame #2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame #3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame #4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame #5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame #6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame #7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame #8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame #9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame #10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame #11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame #12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame #13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame #14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame #15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame #16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame #17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame #18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame #19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame #20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame #21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame #22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread #5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame #2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame #3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame #4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame #5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame #6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame #7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame #8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame #9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame #10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame #11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame #12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame #13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame #14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame #15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615  Co-authored-by: Bernhard Urban-Forster <[email protected]>

Co-authored-by: Stephen Toub <[email protected]>

ViktorHofer and others added 30 commits October 25, 2019 21:40

Update azure-pipelines.yml (#8577)

28e55c8

Revert "Add support to produce WebAssembly runtime assets (#41777)" (#…

76cfbcf

…42127) This reverts commit c57cba7.

Merge pull request #42122 from yukiwongky/readonlycol

c78b718

Fix getting readonly column metadata

Use Unsafe.IsNullRef instead of manual IL in HandleMarshaler.C… (#27443)

a8c9959

[crossgen2] Avoid ambiguous devirtualization (#27424)

d374f8c

Profiler API to modify environment variables (#23383) (#27157)

457449f

Fix build break

5861d42

Signed-off-by: dotnet-bot <[email protected]>

Remove class declarator (#27456)

6fe1637

Use ValueStringBuilder instead of StringBuidler{Cache} in multiple pl…

2969452

…aces

Avoid unnecessary allocations in Exception.ToString

373a7b2

Cleanup SELECTANY (#27459)

7e11363

Remove extra qualifier (#27455)

a2f10df

Use ValueStringBuilder instead of StringBuidler{Cache} in multiple pl…

ea46cd6

…aces Signed-off-by: dotnet-bot <[email protected]>

Avoid unnecessary allocations in Exception.ToString

b123ba4

Signed-off-by: dotnet-bot <[email protected]>

Update dependencies from https://github.com/dotnet/standard build 201…

73e44b8

…91026.1 (#8674) - NETStandard.Library - 2.2.0-prerelease.19526.1

Avoid mod operator when fast alternative available (#27299)

e532bf6

Removing unneeded function calls and empty bodies (#27420)

9a60a6e

Removed unused strings from resources (#27304)

6f2791f

Delete a few more instances of StringBuilderCache (#42139)

bc78f93

Enable building with clang 9 (#27415)

33905fb

* Enable building with clang 9 Update the docker images that we use for building. * Add missing clang9 option to build.sh / build-test.sh * Fix clang version matching and MUSL build * Prevent Clang 9 from optimizing out s_gsCookie write

trylek added 12 commits November 5, 2019 19:18

Update issues.targets to coreclr latest; remove instrumentation

aa18088

Apply my CoreCLR YAML script shuffle

ecc4253

Fix format-job; consolidation-resiliency in setup-stress-dependencies.sh

a4bff13

Apply Viktor's fix for tools-local restoration bug

2a288a8

Fix test host generation in run-test-job

e7e203c

Fix incorrect version of Directory.Build.props / targets

bc137d2

Include previously overlooked CoreCLR change adding more variables

88c181b

Incorrect merge of CoreCLR change (forgot to add src/coreclr)

0025f9f

Cross-compilation fix

c356441

Fix native component build in cross-targeting scenario

1ec9c1e

Fix path to stress dependencies

b2d3d9e

Fix path logic in gen-buildsys.sh

b685389

ViktorHofer closed this Nov 7, 2019

ViktorHofer force-pushed the master branch from 534783a to 9d685ea Compare November 7, 2019 18:11

safern mentioned this pull request Dec 11, 2019

Fix relro, now and PIE for host and libraries #685

Merged

jbatt33 mentioned this pull request Feb 5, 2020

[runtime] Fix the --enable-minimal=aot build. #31684

Merged

sandreenko mentioned this pull request Feb 13, 2020

Keep correct fieldSeq for 0-offset fields. #32085

Merged

fanyang-mono mentioned this pull request Feb 18, 2020

Infinite recursion during resource lookup within System.Private.CoreLib #32510

Closed

oldzhu mentioned this pull request Mar 8, 2020

[ARM32] illegal instruction when run dotnet to create a console project #33344

Closed

fanyang-mono mentioned this pull request Aug 3, 2020

[interp] DynamicMethod with a CALL of a P/Invoke throws "BadImageFormatException: Method has no body" #38897

Closed

karelz added this to the 5.0.0 milestone Aug 18, 2020

eiriktsarpalis mentioned this pull request Sep 17, 2020

Add PriorityQueue<T> to Collections #14032

Closed

panuoksala mentioned this pull request Nov 17, 2020

System.Diagnostics.DiagnosticSource Causing Error Evaluating the function timedout #44503

Closed

lodejard mentioned this pull request Nov 18, 2020

Enhance user-facing API for strongly-typed ILogger messages #36022

Closed

rokonec added a commit to rokonec/runtime that referenced this pull request Nov 26, 2020

Review changes stephentoub dotnet#4

331d034

Co-authored-by: Stephen Toub <[email protected]>

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Initial CoreCLR CI pipeline in the composite repo #4

WIP: Initial CoreCLR CI pipeline in the composite repo #4

trylek commented Oct 31, 2019

WIP: Initial CoreCLR CI pipeline in the composite repo #4

WIP: Initial CoreCLR CI pipeline in the composite repo #4

Conversation

trylek commented Oct 31, 2019