Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable processinfo test for ilasm round-trip testing #39936

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Disable processinfo test for ilasm round-trip testing #39936

merged 1 commit into from
Jul 27, 2020

Conversation

BruceForstall
Copy link
Member

Issue: #39935

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BruceForstall BruceForstall changed the title Disable processinfo for ilasm round-trip testing Disable processinfo test for ilasm round-trip testing Jul 26, 2020
josalem
josalem approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay leaving this test turned off for these legs as a solution since I'm not sure the test would show any ILASM issues that other tests wouldn't also catch.

@BruceForstall BruceForstall merged commit ae067cb into dotnet:master Jul 27, 2020
@BruceForstall BruceForstall deleted the DisableIlasmRoundTripProcessInfo branch July 27, 2020 03:47
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@BruceForstall @Jacksondr5
Disable processinfo for ilasm round-trip testing (dotnet#39936)
65b5feb 
Issue: dotnet#39935
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josalem josalem josalem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BruceForstall @Dotnet-GitSync-Bot @josalem @karelz