[wasm] Fail right away in interp_create_method_pointer () when trying to create a function pointer to a native-to-managed wrapper. #39260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to create a function pointer to a native-to-managed wrapper. The previous method of returning interp_no_native_to_managed doesn't work: * The runtime expects different function pointers for different methods, returning the same pointer leads to all kinds of weird errors. * On wasm, the native caller expects the function to have the right signature, so calling interp_no_native_managed () will leads a to signature mismatch error which is hard to debug.
|
This will cause some tests which worked previously to fail with a PNSE. It will also cause some random failures like |
BrzVlad
approved these changes
Jul 14, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method of returning interp_no_native_to_managed doesn't work:
the same pointer leads to all kinds of weird errors.
calling interp_no_native_managed () will leads a to signature mismatch error which is
hard to debug.