Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS/tvOS/Android to AdditionalBuildTargetFrameworks #38922

Merged

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Jul 8, 2020

Saw these are missing while reviewing #37944.
As far as I can see this is only used when building inside VS but still good to add for consistency.

Saw these missing while reviewing dotnet#37944.
As far as I can see this is only used when building inside VS but still good to add for consistency.
@ghost
Copy link

ghost commented Jul 8, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@akoeplinger akoeplinger merged commit edbb5c8 into dotnet:master Jul 8, 2020
@akoeplinger akoeplinger deleted the additionalbuildtargetframeworks branch July 8, 2020 12:53
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants