Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on new two-line license header #38793

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

stephentoub
Copy link
Member

Replacement for #38732 (trying to fix CI issues)

@stephentoub stephentoub force-pushed the updatelicenseheaders2 branch from f8320f8 to b09550b Compare July 8, 2020 11:27
@stephentoub stephentoub merged commit 6072e4d into master Jul 8, 2020
@stephentoub stephentoub deleted the updatelicenseheaders2 branch July 8, 2020 13:23
@stephentoub
Copy link
Member Author

Failure is #37186

@jkotas jkotas mentioned this pull request Jul 8, 2020
@jkotas
Copy link
Member

jkotas commented Jul 8, 2020

There are about ~200 instances of See the LICENSE file in the project root for more information remaining that were not picked up by your script or that sneaked in in the meantime. Do you plan to do a follow up cleanup of these one-offs?

@jkotas
Copy link
Member

jkotas commented Jul 8, 2020

Ah ... I see you have mentioned the follow up cleanup in the original PR description.

@stephentoub
Copy link
Member Author

Yup, working on it.

monojenkins pushed a commit to monojenkins/mono that referenced this pull request Jul 8, 2020
After dotnet/runtime#38793 tweaked the license header on ~30K files, this cleans up after it, handling another ~1300, and adding license headers where they were missing in .cs files under libraries.  It also adds a default license header to the .editorconfig.

cc: @jkotas
akoeplinger pushed a commit to mono/mono that referenced this pull request Jul 9, 2020
After dotnet/runtime#38793 tweaked the license header on ~30K files, this cleans up after it, handling another ~1300, and adding license headers where they were missing in .cs files under libraries.  It also adds a default license header to the .editorconfig.

cc: @jkotas

Co-authored-by: stephentoub <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants