-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize on new two-line license header #38793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Jul 6, 2020
stephentoub
force-pushed
the
updatelicenseheaders2
branch
from
July 8, 2020 11:27
f8320f8
to
b09550b
Compare
Failure is #37186 |
Merged
There are about ~200 instances of |
Ah ... I see you have mentioned the follow up cleanup in the original PR description. |
Yup, working on it. |
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Jul 8, 2020
After dotnet/runtime#38793 tweaked the license header on ~30K files, this cleans up after it, handling another ~1300, and adding license headers where they were missing in .cs files under libraries. It also adds a default license header to the .editorconfig. cc: @jkotas
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Jul 9, 2020
After dotnet/runtime#38793 tweaked the license header on ~30K files, this cleans up after it, handling another ~1300, and adding license headers where they were missing in .cs files under libraries. It also adds a default license header to the .editorconfig. cc: @jkotas Co-authored-by: stephentoub <[email protected]>
This was referenced Jul 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #38732 (trying to fix CI issues)